“Now I’m a pretty lazy person and am prepared to work quite hard in order to avoid work.”
— Martin Fowler
Last time, we modified the processPhase5 function in the ApplicationPublisher Script Include to use the shared functions for making REST API calls instead of its own code. Now we need to continue with that work and do the same for the processPhase6 and processPhase7 functions. Here is the current script for the processPhase6 function.
processPhase6: function(answer) {
var versionGR = new GlideRecord('x_11556_col_store_member_application_version');
if (versionGR.get(answer.versionId)) {
var host = gs.getProperty('x_11556_col_store.host_instance');
var token = gs.getProperty('x_11556_col_store.active_token');
var payload = {};
payload.member_application = answer.hostAppId;
payload.version = versionGR.getDisplayValue('version');
payload.built_on = versionGR.getDisplayValue('built_on');
var request = new sn_ws.RESTMessageV2();
request.setBasicAuth(this.WORKER_ROOT + host, token);
request.setRequestHeader("Accept", "application/json");
request.setHttpMethod('post');
request.setEndpoint('https://' + host + '.service-now.com/api/now/table/x_11556_col_store_member_application_version');
request.setRequestBody(JSON.stringify(payload, null, '\t'));
response = request.execute();
if (response.haveError()) {
answer = this.processError(answer, 'Error returned from Host instance: ' + response.getErrorCode() + ' - ' + response.getErrorMessage());
} else if (response.getStatusCode() != 201) {
answer = this.processError(answer, 'Invalid HTTP Response Code returned from Host instance: ' + response.getStatusCode());
} else {
jsonString = response.getBody();
jsonObject = {};
try {
jsonObject = JSON.parse(jsonString);
} catch (e) {
answer = this.processError(answer, 'Unparsable JSON string returned from Host instance: ' + jsonString);
}
if (!answer.error) {
answer.hostVerId = jsonObject.result.sys_id;
}
}
} else {
answer = this.processError(answer, 'Invalid version record sys_id: ' + answer.versionId);
}
return answer;
}
The corresponding shared function is pushVersion, which takes as arguments the version GlideRecord, the target instance GlideRecord, and the sys_id of the application record on the target system. We are already fetching the version GlideRecord, we can use the function that we built last time to go get the target instance GlideRecord, and the sys_id of the application record on the target system was stored in the shared answer object in phase 5, so we should have everything that we need to invoke the appropriate shared function and check the results.
processPhase6: function(answer) {
var versionGR = new GlideRecord('x_11556_col_store_member_application_version');
if (versionGR.get(answer.versionId)) {
var targetGR = this.getHostInstanceGR();
var csu = new CollaborationStoreUtils();
var result = csu.pushVersion(versionGR, targetGR, answer.hostAppId);
if (result.error) {
answer = this.processError(answer, 'Error returned from Host instance: ' + result.error_code + ' - ' + result.error_message);
} else if (result.parse_error) {
answer = this.processError(answer, 'Unparsable JSON string returned from Host instance: ' + result.body);
} else if (result.status != 200 && result.status != 201) {
answer = this.processError(answer, 'Invalid HTTP Response Code returned from Host instance: ' + result.status);
} else {
answer.hostVerId = result.obj.result.sys_id;
}
} else {
answer = this.processError(answer, 'Invalid version record sys_id: ' + answer.versionId);
}
return answer;
}
That should take care of the processPhase6 function. Now, let’s take a look at that processPhase7 function.
processPhase7: function(answer) {
var gsa = new GlideSysAttachment();
var sysAttGR = new GlideRecord('sys_attachment');
if (sysAttGR.get(answer.attachmentId)) {
var host = gs.getProperty('x_11556_col_store.host_instance');
var token = gs.getProperty('x_11556_col_store.active_token');
var url = 'https://';
url += host;
url += '.service-now.com/api/now/attachment/file?table_name=x_11556_col_store_member_application_version&table_sys_id=';
url += answer.hostVerId;
url += '&file_name=';
url += sysAttGR.getDisplayValue('file_name');
var request = new sn_ws.RESTMessageV2();
request.setBasicAuth(this.WORKER_ROOT + host, token);
request.setRequestHeader('Content-Type', sysAttGR.getDisplayValue('content_type'));
request.setRequestHeader('Accept', 'application/json');
request.setHttpMethod('post');
request.setEndpoint(url);
request.setRequestBody(gsa.getContent(sysAttGR));
response = request.execute();
if (response.haveError()) {
answer = this.processError(answer, 'Error returned from Host instance: ' + response.getErrorCode() + ' - ' + response.getErrorMessage());
} else if (response.getStatusCode() != 201) {
answer = this.processError(answer, 'Invalid HTTP Response Code returned from Host instance: ' + response.getStatusCode());
}
} else {
answer = this.processError(answer, 'Invalid attachment record sys_id: ' + answer.attachmentId);
}
return answer;
}
The corresponding shared function is pushAttachment, which takes as arguments the attachment GlideRecord, the target instance GlideRecord, and the sys_id of the version record on the target system. Once again, we are already fetching the attachment GlideRecord, we can use the function that we built last time to go get the target instance GlideRecord, and the sys_id of the version record on the target system was stored in the shared answer object in phase 6, so once again we should have everything that we need to invoke the appropriate shared function and check the results.
processPhase7: function(answer) {
var gsa = new GlideSysAttachment();
var attachmentGR = new GlideRecord('sys_attachment');
if (attachmentGR.get(answer.attachmentId)) {
var targetGR = this.getHostInstanceGR();
var csu = new CollaborationStoreUtils();
var result = csu.pushAttachment(attachmentGR, targetGR, answer.hostVerId);
if (result.error) {
answer = this.processError(answer, 'Error returned from Host instance: ' + result.error_code + ' - ' + result.error_message);
} else if (result.parse_error) {
answer = this.processError(answer, 'Unparsable JSON string returned from Host instance: ' + result.body);
} else if (result.status != 200 && result.status != 201) {
answer = this.processError(answer, 'Invalid HTTP Response Code returned from Host instance: ' + result.status);
} else {
answer.hostVerId = result.obj.result.sys_id;
}
} else {
answer = this.processError(answer, 'Invalid attachment record sys_id: ' + answer.attachmentId);
}
return answer;
}
So that wraps up all of the refactoring for the application publishing process. All that is left to do now is to do the same thing for the application distribution process, where the Host instance sends out the artifacts for new application versions to all of the other Client instances in the community. We’ll jump right into that next time out.
